Christian Trott

icon company Sandia National Laboratories icon location Albuquerque, NM, USA icon location High Performance Computing developer with extensive experience in modern architectures (APUs, GPUs, MIC). Lead developer of the @kokkos programming model.

Results 519 comments of Christian Trott

Fix adjacent difference

otherwise looks good.

Incorrect constraints on `View(const View<DT, Prop...> &rhs)`

This was not a bug or mistake: it was a design choice to provide comprehensible error messages. The issue is that the trait `is_constructible_v` is misleading since it only takes...

fix view constructor constraints

I have thought more about this: and I am not sure I want to "fix" this, this way. The basic issue is that `is_constructible_v` does not take into account *mandates*...

layout() function broken for Views with padding -- path forward

Because the code should have used `a_sub.layout()` corrected.

layout() function broken for Views with padding -- path forward

Also accessing stride(2) on a rank-2 view is kinda UB lol

(Rebase) Partial fix to compile time issues w/nvcc + Kokkos_ENABLE_DEBUG_BOUNDS_CHECK

Clang CUDA doesn't work: ``` /var/jenkins/workspace/Kokkos_PR-7013/core/src/Cuda/Kokkos_Cuda_abort.hpp:31:12: error: an attribute list cannot appear here [clang-diagnostic-error] __device__ [[noreturn]] void __assertfail(const void *message, const void *file, ```

Remove support for NVHPC as CUDA device compiler

They removed -cuda from their documented command line options. It used to be there now it's not.

`deep_copy` of `View` of non-trivially copyable type leads to byte-wise copy

Basically we are in somewhat of a bind here. In order to move across memory-space boundaries we may have no option other than to men-cpy but trivially-copyable is too harsh...

Failing Kokkos::HIP Unit Tests

What is the actual GPU you are trying to use? I am running on an MI50 and it seems all to work with your command.

Failing Kokkos::HIP Unit Tests

(Note I was using Kokkos 4.3.01 and ROCM 6.0 not 6.1 which I didn't have on my machine)