Christian Trott

Results 519 comments of Christian Trott

I think the comment about extents could be simpler are fair. Part of the problem was trying to work around a number of issues with empty base optimization in MSVC...

The Kokkos gtest never gets installed, so you shouldn't be able to see it externally.

Yeah we are aware, but 11.3 does not with spectrum mpi with gpu enabled right?

Was just wondering if you got spectrum-mpi to work, or if uou guys simply use openmpi (which anyway would likely be my recommendation too)

@ajpowelsnl can you address the suggestions/requests?

I applied them all.

This is ready for merge the last commit just changed formatting, and the commit before passed testing.

Maybe we should just use the aliases i.e. call: ```c++ if(!is_same_v) Serial::impl_initialize(); if(!is_same_v) DefaultHostExecutionSpace::impl_initialize(); DefaultExecutionSpace::impl_initialize(...); ``` Same for finalize. Then add some actual test in between. ```c++ View data("d",1000); deep_copy(d,1);...