fix: correct detection of obsolete files
closes #775
I am not sure why the exportPattern of a source-file was checked to see that it is obsolete. It works for me without the check, but I would also be happy to fix the check if it's needed and someone could explain me how it should work.
Codecov Report
Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 63.78%. Comparing base (
2d4d0f0) to head (4578ccb).
| Files | Patch % | Lines |
|---|---|---|
| ...i/commands/functionality/ObsoleteSourcesUtils.java | 87.50% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #776 +/- ##
============================================
+ Coverage 63.73% 63.78% +0.05%
- Complexity 1504 1505 +1
============================================
Files 220 220
Lines 6294 6297 +3
Branches 944 944
============================================
+ Hits 4011 4016 +5
Misses 1778 1778
+ Partials 505 503 -2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Not sure where the windows issue was exactly coming from. Probably some path separator mismatch.
@anbraten yes, most likely it is related to paths. We already have some similar tests, and the easiest option here is to have separate test cases for Linux/Mac and Windows operating systems.
These tests have the following annotations:
@DisabledOnOs({OS.LINUX, OS.MAC})
@DisabledOnOs(OS.WINDOWS)
Or we can somehow normalize the paths to unify them for those environments.