Chris Krenn
Chris Krenn
Hello Frank, Thanks for giving me a challenging example! And, this does work the way I intended. I could implement tree links if there was interest, but I think that...
Hello again Frank, Reviewing, it looks like there were at least one question and suggestion: A question: should I keep the new code in utils.py, or should I move it...
@FrankD412, (cc: @jsemler), I think that this is finally ready to merge. Please let me know if you have any questions. Thanks! -Chris
Hello @FrankD412, I fixed a flake8 error. I think it should be finally ready to merge now. -Chris
@FrankD412, (cc: @daub1) Thanks again for the careful review. Regarding: > 1. I ran with the defaults maestro run --make-links ./samples/lulesh/lulesh_sample1_unix.yaml. This appears to work just fine, but it may...
Hello Frank, I think that I've addressed point 2. Thanks for finding the bug! Please let me know if you have any questions. -Chris
Hello Frank, Can you make some time to review this next week? Thanks! -Chris
@FrankD412, I have no objection to waiting for @jwhite242's changes. I'm looking forward to the new status code! -Chris
Sounds good. And, I don't think that the link code currently scans the filesystem tree. It makes parent directories if needed, and it uses binary search if the user has...
@FrankD412, I merged the current dev branch into this pull request. It still passes all tests, but it was not clear to me if there is redundant code that I...