Kristiyan Kostadinov comments

Results 335 comments of


Kristiyan Kostadinov

fix(migrations): migrate HttpClientModule to provideHttpClient()

Caretaker note: the Windows failure is coming in from the main branch and is unrelated.

fix(migrations): migrate HttpClientModule to provideHttpClient()

If you rebase it one more time the Windows issue should go away.

docs: add guide for standalone migration

The feedback has been addressed.

fix(forms): Allow canceled async validators to emit.

[TGP for future reference](http://test/OCL:620438911:BASE:620451780:1711790599794:e9be8756).

NG8011: Node matches the X slot of the Y component, but will not be projected into the specific slot because the surrounding @if has more than one node at its root.

The warning mentions that the component has `preserveWhitespaces: true`. See this line: > Note: the host component has `preserveWhitespaces: true` which may cause whitespace to affect content projection.

Input `transform` does not work if typing is complex

The problem is that the compiler needs to be able to statically analyze the type of the transform function parameter and to reference it inside of Angular's generated code. This...

bug(mat-form-field): Input time element, unexpected behavior when the initial form value is null. Safari

Material doesn't change the value, it just reads it. This is likely an issue with the forms module.

fix(core): allow passing value of any type to `isSignal` function

I just wanted to note that we're currently in a feature freeze which doesn't allow new `feat` commits until v16 is released. That being said, I think that this is...

bug(mat-bottom-sheet): custom form validation is executed multiple times

The bottom sheet doesn't do anything special that would cause the validation to execute multiple times. It's just a dynamically-rendered component that has specific CSS. If there's an issue, it's...

`ng g @angular/core:standalone` should migrate test components properly

Unfortunately we can't do much about this. We use the Angular compiler to figure out what to add to the `imports` array and the compiler doesn't analyze test modules. The...