Kristiyan Kostadinov
Kristiyan Kostadinov
I don't see where the overlay directive is being used in the linked example.
That was my point. Wouldn't that component that is used declaratively be destroyed when you navigate to a different route?
This was done in #27672. Closing.
I agree that it seems weird, but I think that the ideal solution would be not to allow `null` to begin with. I think that defaulting it to `program` is...
It might be easier to talk through it and this change isn't particularly urgent. I'll add it to agenda for tomorrow's meeting.
I'm not arguing that it's a valid usage, but based on the way we've typed it looks like it's valid so we might as well treat it that way.
@mmalerba @devversion I've reworked it based on our discussion.
I've addressed the feedback @mmalerba. I also had to change the signature for a handful of components where we were accepting a `FocusOrigin` and passing it along to `focusVia` directly.
Closing this given how out of date it is and that it'll be a breaking change.
I've rebased this and come up with a different approach to try and minimize presubmit issues. Will run another presubmit to verify.