Thierry Crozat

Currently my mac French version is detected as the mac demo English version. We will need to add some files to the detection to detect properly the full game. And...

I will backtrack a bit from my previous comment, and maybe the solution is indeed to add detection for all the languages, but without including the speech file so that...

This pull request seems incomplete though? If the aim is to use it in engines or video, the functions should have been added to `OSystem`, where they can be directed...

I think the change makes sense. As far as I know the main case where using the old `SDL_WINDOW_FULLSCREEN` is interesting is when using ScummVM on a retro-system with a...

There might be a reason why we might want to make a release build with debug symbols (e.g. for profiling since profiling a non-optimised build is usually useless). What I...

I checked that cmake defines `NDEBUG` for the `RELWITHDEBINFO` build type (which is similar to our `--enable-release --enable-debug` config). And what I currently have in this PR is consistent with...

> Is there a performance impact from keeping asserts in release builds? The performance impact of keeping assert in release builds would be minimal. > If this removes asserts from...

I have added a commit that defines a `scummvm_assert` macro that is similar to `assert` except that it is not disabled by the `NDEBUG` define and that it calls `error()`...

I will merge commit 1d69e7d manually since that one is unrelated to the `assert` and `NDEBUG` discussion and doesn't seem controversial. And I will keep this PR open for now...

I am not sure about using custom defaults (different from the fluidsynth default) as I am guessing what is best will be subjective. But I am not really opposed to...