Flynn

Results 31 comments of Flynn

Hard to say without having more details. I took a look at the shap tests here and noticed that when calling shap_values, `check_additivity=False` is passed. IIRC this was necessary otherwise...

Thanks for adding these maps. I'm happy to add them but I'm not sure about adding CI here. The existing tests are limited and relatively weak and/or broken. It probably...

> How have you run the tests previously? I would just run them locally. Admittedly I didn't put as much effort into this project as I could have. > Something...

We might also want to update the assets here. There is some code in `chicken_dinner.assets` you can run or I can do it separately.

We found that the most common issue of users was name conflicts like these, which wouldn’t manifest until execution time when they would error on the controller, so we added...

@elliotgunton thanks for the review. The changes all make sense to me. I probably won't have time to make them myself until next week, so feel free to resolve them...

There is some discussion here along with a possible solution: https://github.com/tox-dev/tox/discussions/2247

Can you elaborate on how this would work? Would you expect the output column to be StringType() with json string?

I tried implementing this and it's doesn't quite work because of how protobuf is implemented in the schema registry. The confluent package doesn't support this either, presumably for the same...

We would probably want to change some things here since `options` was intended to be a dict of the kwargs of protobuf's MessageToDict. We could probably make the args more...