chicken-dinner icon indicating copy to clipboard operation
chicken-dinner copied to clipboard

added Taego, Paramo and Haven to map_names and dimensions

Open eiriksanderfjeld opened this issue 3 years ago • 7 comments

eiriksanderfjeld avatar Aug 07 '21 23:08 eiriksanderfjeld

Thanks for adding these maps. I'm happy to add them but I'm not sure about adding CI here. The existing tests are limited and relatively weak and/or broken. It probably needs some work before we add CI.

crflynn avatar Aug 11 '21 02:08 crflynn

Right, will remove it and update the PR.

How have you run the tests previously?

eiriksanderfjeld avatar Aug 11 '21 06:08 eiriksanderfjeld

@crflynn Something else you want me to fix?

eiriksanderfjeld avatar Aug 16 '21 11:08 eiriksanderfjeld

How have you run the tests previously?

I would just run them locally. Admittedly I didn't put as much effort into this project as I could have.

Something else you want me to fix?

No, sorry I forgot about this. Taking a look now.

crflynn avatar Aug 16 '21 13:08 crflynn

We might also want to update the assets here. There is some code in chicken_dinner.assets you can run or I can do it separately.

crflynn avatar Aug 16 '21 13:08 crflynn

We might also want to update the assets here. There is some code in chicken_dinner.assets you can run or I can do it separately.

I'll take a look at it; there are some new weapons etc.

rlohne avatar Aug 16 '21 13:08 rlohne

@crflynn Something else we should look into?

eiriksanderfjeld avatar Aug 24 '21 12:08 eiriksanderfjeld