Chad Retz

Results 809 comments of Chad Retz

If you are using a selector for receiving signals, the best way is to continually `selector.Select` until `selector.HasPending()` is false. If you are just operating on that signal directly, you...

As part of the new interceptors proposal at https://github.com/temporalio/proposals/pull/45 client interceptors are supported to allow interception. However, due to the worker still needing internal things from the client, it can't...

The problem here is that the interceptor is for intercepting literal calls to `activity.GetLogger` and `workflow.GetLogger`, not just all loggers. You can provide your own logger at the client level...

My assumption was that `GetLogger` was as a result of a literal `GetLogger` call, and not just before every logger use to make sure it has the latest context info....

After some thought, I am afraid of repeatedly calling `GetLogger` internally instead of its original purpose of only being invoked when the user invokes it. I am worried about going...

Here's the Go change to support opting out of following runs: https://github.com/temporalio/sdk-go/pull/791

At this time, dynamically adjusting such a value is incredibly difficult on the internals due to how pool-transfer would have to work. I'm afraid the current best way to increase...

It appears that https://pkg.go.dev/google.golang.org/grpc/stats is available to provide lower-level stats, I will confirm how it is implemented in gRPC itself and then look to expose that info.

gRPC stats do happen after interceptors. I have made an example of using gRPC stats at https://github.com/temporalio/samples-go/compare/master...cretz:grpc-stats that require dial options exposed in https://github.com/temporalio/sdk-go/compare/master...cretz:grpc-options. Will wait for feedback/updates on how...

@mnussbaum - I may have been able to replicate and this may be showing us an issue we've been seeing. I will confirm and get back.