sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

Refactor NewWorker and remove downcast

Open alexshtin opened this issue 4 years ago • 2 comments

#69 added downcast and panic to NewWorker in internal/worker.go. This needs to be refactored and removed.

alexshtin avatar Mar 18 '20 22:03 alexshtin

I am facing an issue with this at the moment when i attempt to wrap temporal client with my own implementation. Will this eventually be removed, and what is the reason for this explicit check?

jinhong- avatar May 18 '21 13:05 jinhong-

As part of the new interceptors proposal at https://github.com/temporalio/proposals/pull/45 client interceptors are supported to allow interception. However, due to the worker still needing internal things from the client, it can't be wrapped, but all functionality should be available via interceptors.

cretz avatar Oct 19 '21 19:10 cretz