creste
creste
> I have an internal patch that I can clean up and put up a PR. My internal patch also works with annotations post build. @philsc - That would be...
@philsc - Thank you! That is extremely helpful!
I found a workaround for generating a single Swagger JSON file when calling `gateway_openapiv2_compile`. Steps: 1. Patch `rules_proto_grpc` to add a new `openapiv2_plugin_single_output` proto plugin that removes `outputs = ["{protopath}.swagger.json"`...
@anmolanmol1234 - Thank you for the review. I added string constants. Regarding tests, would you mind providing some guidance on what you are expecting? I added [this documentation](https://github.com/apache/hadoop/pull/5953/files#diff-b1b5684dde13128ebedd813dd1b5497dc54d7ce531ddcb105a32043bd4baba22R840-R875) showing how...
@steven13cooper - I'm currently waiting on @anmolanmol1234 or another reviewer to approve the PR or at least [provide guidance](https://github.com/apache/hadoop/pull/5953#issuecomment-1703097859) on how to add more tests.
> Lets add some tests around the change. @saxenapranav - Please see my thoughts on tests [here](https://github.com/apache/hadoop/pull/5953#issuecomment-1703097859). It is not clear to me how to add tests to the code....
@saxenapranav - Thank you for the guidance. I added unit tests and addressed all other feedback.
@sugibuchi @steveloughran - I added the Azure environment variables to the hadoop config documented in the [readme](https://github.com/apache/hadoop/pull/5953/files#diff-8025384b04d948f31f9ee9d3ca74535bfa95decae42ba21c944f6530eae9a857R590). Please take a look when you get a chance.
@sugibuchi - Thank you for the additional comments. >About the descriptions of the four properties, I think we can simply copy-paste the descriptions provided by ADD Workload identity documentation. >...
@snvijaya - My team is no longer using Hadoop and has moved on to another project so I am unable to commit to completing this PR. Feel free to address...