Aaron Stone

Results 9 comments of Aaron Stone

> could you add a test that asserts that when `merge.all` is called with `{ clone: true }`, the first element is mutated/returned? Great call, I hadn't used that entrypoint...

> I like it but I am a little worried about backwards compatibility. As is, this would definitely need to be released as a new major version. You're probably right....

@RebeccaStevens I lied about how long it would take. My wife started watching The Bachelorette and that was my cue to zone out. Let me know if this addresses the...

@TehShrike and @RebeccaStevens - I caught a bug with my in-use fork of this where the merge fails in the case that a target is `undefined`. I pushed a fix...

@RebeccaStevens I can make that change to #209. It might be a few days, but I'll add it to my list.

> So you want a deep [assign](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign) merge, rather than a deep clone merge? Exactly right. 👍

> Wouldn't this me a dup of #186 If I'm understanding it correctly, the `clone` option only takes effect on object values of properties being copied onto the target object....

@TehShrike - Ask and ye shall receive. Thank you for the quick discussion and feedback on the ask!