HF
> You'll need to add unit tests to check this PR does what you expect it to. > > I think the correct place is in the corresponding [`virtctl` pkg](https://github.com/kubevirt/kubevirt/blob/main/pkg/virtctl/vm/vm_test.go)....
> Looks good. I missed a test verifying this change. Can we add one? I have added one in tests/storage.
/assign @crazytaxii
about `check` field: I export a domain XML from actual running VMI: ```xml Cascadelake-Server Intel ``` about `CPUModel` struct: We found Windows VMs running on **Hygon CPU**, libvirt domain XML...
In our customized KubeVirt codes, I firstly detect CPU vendor of the host and define special domain XML on hosts with Hygon processors: ```xml EPYC ``` The Vendor ID and...
The problem is published on my blog, but it's written in Chinese 😥.
> Just to be 100%, that means that using plain host-model with libvirt would result in blue screen, correct? No, we use `custom` (the default one), Windows is still blue...
libvirt and qemu will pass-through the CPU vendor of host if it's undefined in domain XML. For example: ```xml Cascadelake-Server Intel ``` The CPU vendor of VM will be the...