David Crawshaw

Results 70 comments of David Crawshaw

Merged upstream. I can't close your PRs.

@danderson this is I think entirely self-contained so shouldn't need much review.

Hi @majst01, thanks for the PR! Could you please add the `Signed-off-by` to your commits? The WireGuard project uses it as a developer certificate of origin (https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1).

Usually I can do small edits to commits assuming you don't mind, but it feels a odd for me to add signed-off-by lines for you. :) If you wouldn't mind...

As you are rebasing, would you mind making it interactive `git rebase -i --signoff` and set each commit to 'r' (for reword), then please modify the commit messages so they...

I haven't tried out sticky sockets yet (I didn't bring my linux machine and haven't set up another one yet), but I don't think it blocks this commit. That code...

Sorry I completely missed the implication of your comment. I thought you were asking if sticky sockets still work in the code that predated this commit, not after. As such...

Somewhere, sometime, someone gave me a recipe for demonstrating sticky sockets with two interfaces on linux. @zx2c4 was it you? I can't find it anywhere in my notes.

Some of this I believe is justifiable, some less so. The main CreateEndpoint/CreateBind callbacks are very useful to several different kinds of projects, which generally fall under the umbrella of...