wireguard-go icon indicating copy to clipboard operation
wireguard-go copied to clipboard

Published 20 hours ago • verified publisher icon WireGuard

device: return generic error from Ipc{Get,Set}Operation.

Open danderson opened this issue 4 years ago • 4 comments

This makes uapi.go's public API conform to Go style in terms of error types.

Signed-off-by: David Anderson [email protected]

danderson avatar Apr 01 '20 16:04 danderson

cc @crawshaw replaces #7 with more complete coverage. I said in that PR I'd send a complementary change for just IpcGetOperation, but it ended up being easier to just fix both at once. I suggest merging this one and closing #7 ?

danderson avatar Apr 01 '20 16:04 danderson

LGTM

crawshaw avatar Apr 02 '20 03:04 crawshaw

Merged upstream. I can't close your PRs.

crawshaw avatar Apr 02 '20 03:04 crawshaw

This might have implications for wireguard-android, wireguard-windows, and wireguard-apple:

https://github.com/WireGuard/wireguard-android/blob/master/tunnel/tools/libwg-go/api-android.go#L86-L91

https://github.com/WireGuard/wireguard-windows/blob/master/tunnel/service.go#L199-L204

https://github.com/WireGuard/wireguard-apple/blob/master/wireguard-go-bridge/api-ios.go#L107-L111

zx2c4 avatar Apr 05 '20 03:04 zx2c4