katelyn martin

Results 133 comments of katelyn martin

thanks for your patience! i have opened #244 to provide an accessor that will clone the metric `M` rather than returning a RAII guard.

> @cratelyn do yall have a more extensive suite that includes balancing that can test this change out? we do! i'll try running the linkerd2-proxy tests with this patch applied,...

if this change is focused on solving how this middleware interacts with a `Balance` service, i might suggest adding a test case that exercises the buffer with a `Balance` service.

> > @cratelyn do yall have a more extensive suite that includes balancing that can test this change out? > > we do! i'll try running the linkerd2-proxy tests with...

> @cratelyn you've since ported all of linkerd to use the newer hyper/tonic, I think, right? If it'd be easier to pop this branch and see if the test suite...

hi there @mrtworo, thank you for filing this issue. i've tried to reproduce this issue using this proxy version, but when i curl the proxy's metrics endpoint i do not...

after further investigation, i was able to reproduce this, and have identified a fix. more to come soon, i will follow up when a pull request is in review, and...

this is fixed in linkerd/linkerd2-proxy#3987! this should be included in an edge release this afternoon.

this is fixed in https://github.com/linkerd/linkerd2/releases/tag/edge-25.7.1. it's worth pointing out that because of the edge release paradigm that Linkerd follows, this issue will persist when upgrading from versions prior to 2025.3.2....

i'm not sure if there is comet behavior involved when you say "_full node panic_" but yes, `unimplemented!`, `todo!`, and co. will cause the current thread to [panic](https://doc.rust-lang.org/stable/src/core/macros/mod.rs.html#817). if panics...