Results 269 comments of crasbe

I agree that using ENABLE_ON and ENABLE_OFF is more elegant. I can test the latest version tomorrow, but I wouldn't expect any problems. One more thing that might be worth...

Was the change of the bmp.py file supposed to smuggle into the PR?

That is odd, stdio_uart does not care about the return value of uart_write and uart_write is the only function that calls get_power. I don't have a nRF52840DK at home, so...

I don't understand why the Github search does not find these files, but hey, it would've been too easy I guess. Maybe it is just stack related? When get_power is...

It probably won't help if I say "works for me" :eyes: The result is the same without the USEMODULE and it works with "BOARD=nrf52840dk make flash term" as well. ```...

The board I have here is a PCA10056 Revision 3.0.1 from 2023.6. The nRF52840 has the following text written on it: ``` N52840 QIAAF0 2232AQ ``` QIAAF0 means that the...

@benpicco I think I found a suitable solution to get rid of the Kconfig configuration options and have a versatile option to enable manufacturer dependent security options. The mtd_spi_nor_params_t struct...

The static-test codespell complains about these lines in drivers/mtd_spi_nor/mtd_spi_nor.c being a typo (it would like to have WELL instead of WEL): ``` /* Wait for WEL to be set */...

> > Interestingly it does not occur when I run "make static-test" locally. > > the static-test checks if the tool that is running a test is installed - so...

Okay, this was a bit naive of me. Obviously the spellcheck only checks with the ignored word list that is currently in master. So either I have to ignore the...