crasbe
crasbe
I did some more work finding out about why the `JLINK_POST_FLASH` variable is ignored. Another test I did is to see if the `JLINK` variable, that is defined in `boards/common/nrf52/Makefile.include`...
@cladmi Thank you for taking time to explain this a little more to me. > From looking in #15475 I would expect `jlink.inc.mk` to be loaded by https://github.com/RIOT-OS/RIOT/pull/15475/files#diff-3c8fb3a3507e1db4ca93b4d7b28883c763dc084a2ca0dc45adc907d9e4abedefR405-R407 > >...
> Changing `flash%` to `flash flash%` seems like a good fix. > > Either as a quickfix only here first if that unblocks you and plan to fix the rest...
I just looked at the other code in the file and it does not use `_Msk` at all, only the code I introduced. For consistency it would probably be best...
@kfessel Can I resolve the conversations and squash the fixups?
Is there anything left to do for me? I think @benpicco and @kfessel were generally approving of the PR?
Thanks everyone for working with me on this. Even though it was a small change, I still learned a lot :)
It looks like this is your first Pull Request? It looks very good for a first PR :) You probably noticed the failed "static tests", this is due to some...
I tested the PR today and everything works as expected. My only two remaining remarks are: 1) The beacon function in the test program is called `send`, which doesn't make...
> @crasbe I think your two comments have been addressed, right? Yes 👍