crasbe

> > better to use ztimer_msec > > not sure, usually you must be prepared to be off by +- 1 timer tick Unfortunately I can't give a qualified answer...

I poked Martine today (twice even) and another experienced RIOT dev, but there is not a clear answer. The underlying "tick" depends on the frequency of the timer that is...

Okay, since Makefiles aren't supposed to check the `FEATURES_` variable, I had to move the image variant selection into the recipe where the `USEMODULE` variable is fully resolved. It is...

This is pretty much on hold until the riotdocker PR is merged anyway, but thanks for testing :)

I think something with your rebase went wrong, you have two commits in the PR that are part of the master branch from benpicco and maribu.

Yes, it looks good now. Unfortunately I don't have a dwm1001 board for testing this. I'm not a maintainer, so this is not an official review. I took a quick...

I think you don't have to make any significant changes to the original project to be compatible with the RIOT definitions. There are different possibilities like checking for some environment...

Unfortunately it still fails, it appears that `xipfs_config.h` is still included in `xipfs.h`: https://github.com/2xs/xipfs/blob/main/include/xipfs.h#L40 Removing that include makes it somewhat work, but of couse, there is no place now that...

I think the easiest approach would be to create a `boards/riot/xipfs_config.h` file with the following content: ```c #ifndef XIPFS_CONFIG_H #define XIPFS_CONFIG_H #include "cpu.h" /** * @def XIPFS_PATH_MAX * * @brief...

I would assume that this line is creating the error: https://github.com/GGuche-2XS-Univ-Lille/RIOT/blob/3b1d69ade827f4cc684a00f7fbe0da1e3deac0c2/pkg/xipfs/Makefile.include#L2 The fake folder is not a good solution IMO.