crasbe
crasbe
> which one do you mean? Nevermind, there is no group-opening operator in the `doc.txt`.
LGTM, IMO this is ready for merge.
Not sure if it makes sense to split it now, but it would've been better if it had been split to begin with. There are already many things to test...
Yes, please squash. I was waiting if @benpicco has something else to note, but if not, you can hit merge at your own discretion.
@mguetschow: mind taking a look at this to see if it is still relevant and we want to have it?
> as almost any change I make in the code causes it to disappear I had a similar issue when the number of waitstates for Flash accesses was incorrect. For...
Would you mind creating a "DELETEME" commit that adds the two boards to the `.murdock` file, so that the CI tests actually are meaningful? :)
I resolved some of the review comments that were fixed, but here are the ones that either haven't been addressed yet or where I'm not sure if they should be...
The reason for the failed build is that the `RP2350.h` also defines `BIT0`, but in a struct: https://github.com/raspberrypi/pico-sdk/blob/a1438dff1d38bd9c65dbd693f0e5db4b9ae91779/src/rp2_common/cmsis/stub/CMSIS/Device/RP2350/Include/RP2350.h#L674-L695 I guess there are two ways around that: either do a lot...
> > The reason for the failed build is that the `RP2350.h` also defines `BIT0`, but in a struct: > > https://github.com/raspberrypi/pico-sdk/blob/a1438dff1d38bd9c65dbd693f0e5db4b9ae91779/src/rp2_common/cmsis/stub/CMSIS/Device/RP2350/Include/RP2350.h#L674-L695 > > I guess there are two ways...