Craig Kovatch
Craig Kovatch
@sophiebits sorry accidentally clicked the 'X'. This can degrade performance if there are filtering operations or server callbacks used in the change event handlers. The approach shown in https://github.com/facebook/react/issues/3926#issuecomment-316049951 is...
> @hellendag I think we should not fire onChange until the IME string is committed. I don't think this is a valid solution as a component might want to know...
`@types/*` dependencies are `devDependencies`, so they aren't pulled into the published package artifact. In this case you're publishing your typing file along with your library, which to my knowledge isn't...
@kamontat that would completely remove all member type safety from the global `String` interface.
My package doesn't use `colors`, that's the problem :) My package consumes a package which consumes a package which consumes `colors`, but because these typings are written against the global...
It would probably be worth asking someone on that side if they have other ideas. I'm not claiming to be the world's expert or anything :) I think what you're...
Good point! I will investigate and get back.
@Marak @DABH no, it would not appear that String is overloaded at runtime. This issue is just about pollution of typings.
I too see this with `mount` in 3.10.0 Pinging @ljharb since this issue has been open for many months without response, perhaps it fell through the cracks?
I unfortunately don't remember what my repro case for this was, but I do remember I was on React 16.8.6 and enzyme 3.10.0