Craig Davison

@shekhei you can use https://github.com/nodejs/http-parser/pull/342/files?w=1 to see the diff without whitespace changes. BTW it looks like the style in this file is to use lower-case for labels, not upper-case as...

As I mentioned in the linked bug report, I do have a (bad) workaround for when CGO is not desired, and I'll describe it here in case you find it...

@brackendawson Updated as suggested. PTAL

@brackendawson Thank you for the review. It looks like I still need an approval before this can be merged.

@dolmen This modifies the error string, not behaviour, and I'm not sure there are any existing test cases for error strings. Do you want me to add a test case...

@dolmen Actually it should be straightforward for me to add tests for unwrapAll and buildErrorChainString. I can do that now.

> We don't want tests that test details of the actual implementation. Good tests must only use the public API of `testify`. To be clear, you do want these new...

@dolmen PTAL

@dolmen Wanted your thoughts on the tests - am I on the right track? Thank you

@dolmen I added the tests in #1435. I'll also split out a new PR for the go 1.20 error wrapping handling.