Colin Raffel

Results 195 comments of Colin Raffel

Ok, I will leave it to you all to decide how best to improve the docs (since I don't understand the issue and probably won't).

Should we change this: https://github.com/craffel/pretty-midi/blob/0ada945d18d1cbc498db957a715ddee8944c64e6/pretty_midi/fluidsynth.py#L15 to a float then?

> I'd like to take a stab at this. Cool, contributions welcome. @justinsalamon will know best what is necessary. > Seems like the way to do this is add a...

`mir_eval.beat.f_measure` only returns F-measure because only F-measure is used by the beat evaluation toolbox and MIREX; `mir_eval.onset.f_measure` returns all three because MIREX uses all three. I'd potentially support changing `mir_eval.beat.f_measure`...

Seems reasonable, but changing the output pattern of the function will break backwards compatibility, so can't be taken lightly. In particular, if there is scarce interest in this, I would...

@georgid > Can you provide an example input and output of the proposed behavior? If not or all is ok, we will close the issue.

Hey, thanks for this. To be honest I don't think that corrupt MIDI files should be read in this manner - it seems dangerous to arbitrarily clip any non-127 data...

In that case I would suggest wrapping your MIDI file loading in a try/except and skipping the problematic files. If a data byte is > 127 I would treat the...