Colin Raffel
Colin Raffel
Yes, that would be fine. I don't think the order of the blocks is terribly important as long as all cases are handled.
Thanks, but pkg_resources is still used to get the default SF2 path: https://github.com/craffel/pretty-midi/blob/280352a75c53901eb9b0e4f4dffa416ad041fa33/pretty_midi/fluidsynth.py#L52 That would need to be fixed (and we'd need to verify that, after applying this PR, the...
No, markers are not a meta message that pretty_midi stores, since it doesn't really affect playback or any characteristics of the song. No reason support couldn't be added though, PRs...
I didn't realize people were using it for the second use-case you had listed; in that case the interpolation doesn't really make sense. I think it makes sense to interpolate...
> How about interpolating over, say, two cycles at the frequency being synthesized? This seems fine unless there's an interval which is shorter than two cycles of the frequency. Then...
I do not know music theory :( @bmcfee ?
Thanks Brian. Maybe as a preliminary step we could add an arg that specifies whether to use a LIL matrix or an ndarray?
Thanks Caleb. Apart from PEP8 stuff, you'll also need to add separate evaluation for chroma metrics to `mir_eval.transcription.evaluate`, e.g. forcing the value of `chroma` in the `kwargs` dict to be...
Now that the MIREX website is back up, can we move forward on this?
> I'm a bit confused about comparing to MIREX results. The existing output*.json files don't match the differences from this comment, so I'm not sure what to look for when...