Junghyun Nam

Results 10 comments of Junghyun Nam

It seems like I cannot assign a reviewer for the PR(the template indicates me to do so), so not assigning.

Piping tests now run on unix platforms only(as the `-` substitiution applies only on unix too). Double buffering issue is resolved. What do you think about implicitly allowing access to...

I simplified the strategy to detect piped files(directly invokes `is_fifo` on Unix) and fixed tests incorrectly set up.

@jameysharp Thanks for your detailed guidance! I didn't think fixing this would not be hard this way and admittedly I couldn't do some sort of refactoring the project(and even adding...

@nektro What platform are you testing on? I'm on MacOS aarch64 13.3.1a(Ventura), and `zig build run` downloads the module without any issue. I removed `~/.cache` and `zig-cache` to ensure the...

Hmm that differs. I think we should wait for https://github.com/ziglang/zig/issues/15590 to be resolved first?

Still fails on `0.11.0-dev.3262+df909da5d`. Updated the instructions. (FYI the getty maintainer temporarily removed the 'clean' step on the latest master, so you may not reproduce the issue correctly if used)

Rebased and implemented the @jameysharp 's guidance. (I'll move to a new pull request as the topic has changed, so please leave this PR not reviewed)

`cargo check -v` output: ``` ...snip... error[E0308]: mismatched types --> /Users/namjh/.cargo/registry/src/github.com-1ecc6299db9ec823/curve25519-dalek-3.2.1/src/backend/serial/u32/scalar.rs:373:40 | 373 | Scalar29::montgomery_mul(self, &constants::RR) | ------------------------ ^^^^^^^^^^^^^^ expected struct `Scalar29`, found struct `Scalar52` | | | arguments to...

Agreed. The weird part is that the `kx-test` repo only adds `crypto_kx` as a dependency.