Chris Povirk

Parameter of `Integer.parseInt` and friends: `@Nullable` or not?

19

I'm not sure if this warrants its own issue, but I just got asked about it inside Google, so I'm re-posing the question here for anyone who might be interested....

Consider annotating `InvocationTargetException`, `ExecutionException`, and `CompletionException` causes as non-nullable

8

First, [`InvocationTargetException`](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/reflect/InvocationTargetException.html). Points in favor of non-nullable: - The no-`Throwable` constructor overload is `protected`, not `public`—and AFAICT is unused both in the JDK and Google's codebase. - Every `InvocationTargetException` that...

AtomicReference.compareAndSet: `(V?, V%)` or `(V%, V%)`?

4

We already [decided on](https://github.com/jspecify/jspecify/issues/145) and [wrote about](https://github.com/jspecify/jspecify/wiki/nullness-borderline-cases#the-atomicreference-case) `AtomicReference` in general, with emphasis on its no-arg constructor, settling on: ```java @NullMarked class AtomicReference { AtomicReference(V initialValue) {...} AtomicReference() {...} // the...

Standard set of declaration-annotation equivalents to `@Nullable` and `@NonNull`

2

I'm opening this issue because I thought we already had an issue filed about it, but I can't find it. Maybe I can't find it because I'm confusing "declaration vs....

We've generally been OK with saying that JSpecify doesn't get into the business of saying things like "Non-`@Nullable` fields must be initialized by the end of the constructor." (There are...

Javadoc "Why?" links don't appear to include the section header

2

Probably bitly dropped it at creation time? ``` $ wget https://bit.ly/3ppb8ZC ... Location: https://docs.google.com/document/d/1H3TdqjRZQiGEP7ZePLpTnbYxj9s5hJAn9sp6eOiuj_c/preview [following] $ wget https://bit.ly/3ppb8ZC ... Location: https://docs.google.com/document/d/1H3TdqjRZQiGEP7ZePLpTnbYxj9s5hJAn9sp6eOiuj_c/preview [following] ``` So all links dump you at the...

Move module-info back to the main root?

4

Currently, it's under the 9+ section of the mrjar. That's fine, but I wonder if we'd be better off getting modular-style Javadoc output, as we might if we moved it...

Call `DateTime(long)` instead of `DateTime(Object)`.

27

The latter uses `ConverterManager.getInstance()`, which is not thread-safe: https://github.com/JodaOrg/joda-time/blob/main/src/main/java/org/joda/time/convert/ConverterManager.java#L89 We learned of this inside Google because of a report by TSAN. I don't know whether simple changes like this are...

build(deps): Bump Truth to 1.4.2.

1

This requires adapting to Truth's recent nullness annotations. Specifically, a `Subject` constructor (and the associated `Subject.Factory` and `assertThat` function) should accept a null actual value. By doing so, it makes...

Improve `guava-android` Animal Sniffer compatibility testing for Java 8+ APIs

2

As of [33.2.0](https://github.com/google/guava/releases/tag/v33.2.0) (and even slightly earlier for package-private and `guava-testlib` APIs), we have APIs in our Android flavor that require library desugaring. For them, we disable Animal Sniffer. We...