Chris Povirk

Make Expect throw ComparisonFailure when possible

2

Currently, it always throws `AssertionError`. But if there's only one failure and it's a `ComparisonFailure`, we should throw `ComparisonFailure`. Arguably we could throw `ComparisonFailure` even in the case of multiple...

Should hasMessageThat() have a null check for "Causal chain is not deep enough" like hasCauseThat() does?

1

We added this way back in the original `hasCauseThat()` implementation in CL 143231718: https://github.com/google/truth/blob/29f6df4f068c2b888723a060a694cdd861cb081d/core/src/main/java/com/google/common/truth/ThrowableSubject.java#L71-L75 I don't remember ever discussing whether to do it for `hasMessageThat()`, too, but the case seems...

In containsExactly, hash elements when we can

3

(This could improve performance in some cases.) Currently, we avoid hashing in all cases, just in case it doesn't work for some objects. But hashing does work for the vast...

Here are some things we should consider for the next feature push after 1.0, even though they would involve changes to projects other than Truth: - [Multline-friendly `toString()` for AutoValue](https://github.com/google/auto/issues/730)...

Decide and document how inOrder() works with Multimap

7

Currently, it checks that the `keySet` is in the expected order and that the values for each key are in the expected order. This is different than checking whether all...

Provide PrimitiveIntArraySubject.asList().containsExactlyElementsIn(int[]), etc.?

1

Seems worth a look, since we have similar methods on `PrimitiveDoubleArraySubject` and `PrimitiveFloatArraySubject`? But we'd have to look to establish demand. And there's also the possibility that we'd make `PrimitiveIntArraySubject`...

Expand and externalize our docs on writing your own Subject

18

We have some docs internally. Other things for us to cover: - Don't throw `AssertionError` directly: Call `this.fail()`: - `fail()` generates the appropriate type of failure (e.g., `AssumptionViolatedException` when someone...

isInstanceOf/isNotInstanceOf can't find supertypes under GWT (if class metadata is off?)

4

If I adopt `isInstanceOf` in Guava, various tests fail. These are tests that worked fine with `assertTrue(foo instanceof Bar)`. Truth has special support for `isInstanceOf` under GWT, but it can't...

Policy describing the difference between "check failed" and "could not evaluate check"

10

``` assertThat(myList).containsExactly("foo", "bar"); ``` If `myList` is `null`, we throw `NullPointerException`. This is different than calling `fail()` -- and not just because `NullPointerException` is different than `AssertionError`. The more important...