Chris Povirk

Update code to prepare for nullness annotations in rxjava3.

5

(In addition to keeping the code compiling in the future, this change should make some runtime nullness errors impossible.) rxjava3 nullness annotations don't yet trigger Kotlin compile errors, but that...

Run tests under Java 17

6

We would want to detect anything that breaks with more recent versions than what we currently test with (Java 11). To do so, I'm told that we'll have to omit...

Should shutdownAndAwaitTermination and awaitUninterruptibly be @CheckReturnValue?

2

(For that matter, `ExecutorService.awaitTermination` itself -- though that change would ideally be made in Error Prone itself, rather than in our subclass `ListeningExecutorService`.) I just had a bug in my...

Make a JSpecify-annotated Guava available for testing purposes

1

A few months ago, we pushed [a branch](https://github.com/google/guava/tree/jspecify-preview) annotated with [JSpecify 0.2.0](https://github.com/jspecify/jspecify/releases/tag/v0.2.0) [`@Nullable`](https://javadoc.io/static/org.jspecify/jspecify/0.2.0/org.jspecify/org/jspecify/nullness/Nullable.html) and [`@NullMarked`](https://javadoc.io/static/org.jspecify/jspecify/0.2.0/org.jspecify/org/jspecify/nullness/NullMarked.html) annotations. This may be useful to authors of tools who want to consume those annotations...

Improve `Iterables` doc around migrating to `Stream`

3

We're seeing some evidence that people are interpreting the current text as "You should always choose `Stream` over `Iterables`" and even as "`Iterables` is effectively deprecated." I don't remember all...

Docs: "How to use Guava for GWT"

2

- Look for `@GwtCompatible` annotations on the types you want to use. - The GWT module for a package is usually `com.google.common.foo.Foo` (perhaps _always_, but there could be exceptions with...

Remove @Beta from Futures.transform, catching, and *Async variants

3

These methods are very heavily used internally. They're probably less so externally, but that may change as AndroidX exposes `ListenableFuture` in more APIs. Plus, Dagger Producers uses these methods. Blockers:...

Don't move comments when moving `load()`

1

I don't know if I quite believe that I want this or not, but: ```python $ cat BUILD foo(name = "foo") # some comment load("//some:file.bzl", "bar") bar(name = "bar") ```...

Make new_load add loads in sorted order when possible

1

I understand that some files have out-of-order loads to begin with (or even loads scattered across the file). But when the existing loads are sorted, it could be nice to...

``` $ touch WORKSPACE $ echo 'package_group(name = "group", packages = ["//..."])' > BUILD $ bazel --version bazel 3.3.0 $ bazel build ... ... INFO: Build completed successfully, 1 total...