Christoph Nakazawa
Christoph Nakazawa
Probably needs a big rebase/merge.
Sorry for the late response, it took me a moment to get back to this PR. I left a few comments – am I right in assuming the biggest challenge...
Got it! It looks very similar to how I would have implemented it, so I'll try to take a look through all the possibilities of where things could go wrong...
That's awesome, thank you for the PR! I left a few comments to make sure we aren't breaking something across maps by caching data globally. Could you also share the...
> > Could you also share the benchmark you used? > > I used the [benchmarkify](https://www.npmjs.com/package/benchmarkify) library with the mock data from the first test in ([Radius.test.tsx](https://github.com/nkzw-tech/athena-crisis/blob/main/athena/__tests__/Radius.test.tsx?rgh-link-date=2024-07-08T02%3A24%3A43Z)) That's great. Can...
Thanks for the updates! I realized that we can actually avoid all of the extra complexity and don't need to add an LRUCache. The radius cache is specific to a...
Thanks for the updates, I think we are getting closer to something that can be merged. As for the benchmark, it's not super representative to run it on the same...
I added the benchmarks right to the repo using `pnpm vitest bench`: https://github.com/nkzw-tech/athena-crisis/commit/5d3bc85d50732b6846885f99c26da53655f713f3 Feel free to extend them as well.
@rortan134 are you planning on getting back to this?
Closing due to inactivity. Happy to reopen if it's being picked up again.