Christine Poerschke

Hi @neshang - it was nice to meet you at the hackathon yesterday and to collaborate on the #3751 issue. Thanks especially for spotting that the initial `git_signature_..._env` implementations did...

Pull request now updated to include docs in signature.h and CHANGELOG.md entry. Yet to look fully at the 'AppVeyor build failed' partial failure, from a quick look it seems unrelated?

> Great. > > Add a CHANGES entry. I may try to re-format the RefGuide edits from the patch later... Thanks for attaching SOLR-13681-refguide-skel.patch to the JIRA ticket! If you...

Wondering if the comparators becoming static _and_ moving into a separate class might also be something to consider, to make them (perhaps) more discoverable for use in tests?

Via https://github.com/apache/solr/pull/757#discussion_r836881993 it was highlighted (no pun intended) that `hl.queryFieldPattern` is ignored if `hl.requireFieldMatch=true` is set. So then if (and that remains an if) the Admin UI had the `hl.queryFieldPattern`...

Hi @jeanielamwh, thanks for opening this pull request! Just FYI that I'm going to edit the title and description to remove the direct SOLR-16111 reference (now that #757 is merged)...

> ... Is there any reason not to merge this test? ... Thanks for the ping! From (very vague) memory the test/code behaviour was non-deterministic and part-mysterious, though maybe the...

> ... maybe the `continue;` with the `// SOLR-10059: sometimes (but not always) filterQueriesList contains duplicates` fully accounts for that. ... Looks like it does. Also just merged latest`origin/main` into...

> @cpoerschke I wanted to get this sorted, any chance you could be another set of eyes???? From looking at the changes I'm wondering if [RequestUtil](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.0/solr/core/src/java/org/apache/solr/request/json/RequestUtil.java#L51-L52) might be an alternative...

> ... no cloud setup test though ... #426 is about adding a `SearchHandlerAppendsCloudTest` test.