Celine Piraux

Results 9 comments of Celine Piraux

Sorry for my late reply, I was on vacation. I was able to generate the issue by adding a sheet ‘README’ in the mock_spec.xlsx file from this package. ![image](https://github.com/atorus-research/metacore/assets/69685640/d1b43bf6-ddcb-40a9-b47a-15a83e26d7a8) And...

In my excel file, there are also some sheets with more details for derivation with domain name in it. ![image](https://github.com/atorus-research/metacore/assets/69685640/9b6ccc07-57f7-4baf-8d61-04d3157e2ca1) Would it be possible to have the possibility to exclude...

Thanks @mstackhouse! I had a look to the vignette and indeed each function allows to select sheets individually, so there might not be a need to exclude them. I was...

I think it would be helpful to have a function that selects variables. I like the message from metatools::drop_unspec_vars that lists the dropped variables, and I suggest having a similar...

The Roxygen header will be updated to ensure consistency across all functions. Please refer to the Style Guide for Roxygen Headers in the wiki for more details. https://github.com/atorus-research/xportr/wiki/Style-Guide-for-Roxygen-Headers

> What are your thoughts, in terms of listing the variables dropped? > > ![image](https://user-images.githubusercontent.com/90790226/241574318-35823891-4620-4d28-ba36-112bd1e980c9.png) > > or > > ![image](https://user-images.githubusercontent.com/90790226/241574434-e017bca8-73d3-41a9-a988-37c00e649676.png) > > or if anyone can think of something...

Great! It's good to hear that the implementation is already done. I took a look, and it seems to be ok.

I am adding an example for more clarification. The XPT requirements and those from regulatory agencies can differ. For instance, let's examine the distinct requirements for dataset and variable labels:...

I have created another diagram for the coercion process. In this diagram, we have a list of different datatypes and the coercion flow. If the 'R' datatype is different from...