Kaushik Amar Das
Kaushik Amar Das
> I've also sent PR for adding algorithm of factorial to Math. I have merged your PR. Thank you for your contribution!
> Thanks for your kind response. > You should actually notice that you mustn't change the file name from factor.m to factorial.m, because Matlab already has a function with the...
@atousa1 @MaSi-dev I have added more problems to the math section, have a look! :)
Hi, I will review it soon. Thanks! On Sun, 2 Feb 2020 at 13:18, MatteoRaso wrote: > I made a PR for an insertion sorting algorithm. > > — >...
There is already a version of selection sort in the repo https://github.com/TheAlgorithms/MATLAB-Octave/blob/master/algorithms/sorting/select_sort.m I will merge yours as an alternative implementation if you give a good enough reason. Thanks :)
Please add a link to a reputable site, perhaps Wikipedia, where the algorithm is explained as a comment in your code. Thanks!
> > Please add a link to a reputable site, perhaps Wikipedia, where the algorithm is explained as a comment in your code. > > Thanks! > > Added in...
If you could please share a Colab Notebook reproducing this error it would be easier for me to investigate the issue.
Hi, thanks for reaching out. You are not wrong. Adding one at the end should be sufficient. I just wanted to better mark sentence boundaries. I would suggest you take...
@oscardssmith optimizer.optimizer.state_dict() seems to solve the issue for me. But i still think, there should be a state for the entire optimizer as whole.