Tatu Saloranta
Tatu Saloranta
Excellent, thank you @Bluexin! The only other thing I need now is CLA (unless you have sent one earlier, if so let me know). It's here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the usual...
@Bluexin um, did you do the usual `mvn clean test` verification with this patch? Looks like this breaks a whole lot of test cases. I think the logic defined was...
@Bluexin I do not usually run all test from IDE; part of the reason is that `mvn test` will skip tests under `..../failing/` -- but IDE has no idea that...
CI still reports tons of failures: ``` Tests run: 3694, Failures: 51, Errors: 4, Skipped: 0 ``` so I can't really proceed with this until those are better understood.
@Bluexin ah. That makes sense. Thank you for following up; I should have caught that. It is kind of obscure issue. I wish this came up 1 week ago before...
@Bluexin no problem, we all have other important things to do. I appreciate you getting this done whenever you could!
No problem @Bluexin I can just use PR id instead of issue; have done it in the past.
Sounds like there perhaps would need to be another constructor overload (taking `base` and new ExternalTypeHandler); adding new argument to existing constructors would likely be major incompatibility source (or require...
One quick note: I think I'd prefer only testing on LTS versions if at all possible. Use of preview never seems to work very well across various tools. Other than...
@sigpwned Let me change the `failing` matching to allow other locations. Done. Should allow placement wherever, tests under `**/failing` should now be ignored by junit runs (but can run manually...