Scott K Logan

Results 9 comments of Scott K Logan

Thanks for triaging all of these old tickets, @pietern. > Were you trying to get a build working without the `vendor` directory (submodules)? Indeed I was. I'd love to see...

I've encountered this as well. I believe that unrelated changes have caused the `HAVE_THREAD_SAFETY_ATTRIBUTES` check to fail during configuration, so `-DHAVE_THREAD_SAFETY_ATTRIBUTES` isn't set and the annotations aren't actually added. If...

@kunaltyagi, your patch worked for me on Fedora 32. It would be great to see this merged.

I'm using the released version of cartographer for Eloquent, not master. That change appears to affect the include directories, but this issue describes a linking problem. I tried applying the...

It looks like mypy on Debian, Ubuntu, and Fedora doesn't actually use a discrete "typeshed" package even if available, and rather bundles typeshed as `mypy.typeshed`. Would it be possible to...

> From what I can tell `mypy.typeshed` only has `stdlib` types and not typeshed's stubs folders. Thanks for checking. Is my understanding correct in saying that your goal is to...

When building an `ament_python` package, colcon will use whatever python interpreter it was built for. If you install it from debs, it should use the system's default interpreter. If you...

> One thing I noticed when looking at ament_vendor: did you test the RPM builds work for you with the ament_vendor() function? Yes, there are multiple packages passing RPM builds...

Also note that `ament_vendor` completely disables `ExternalProject_Add`'s semi-broken repository fetch mechanism in favor of the `vcstool` package used frequently with ROS. So there is no "update" phase when using `ament_vendor`,...