CossonLeo

Results 13 comments of CossonLeo

> We might need to call `.savepoint` sooner, inside `fn completion` rather than here > > https://github.com/helix-editor/helix/blob/0062af6a19d96e0a4c3f94e3e44c179230e005b9/helix-term/src/ui/completion.rs#L152-L153 Yes In the current implementation, there are still redundant characters. It occurs when...

> How to reproduce the issue? Although it is a small regular event that affects normal editing gopls 0.7.0 helix 0.6 .config/helix/config.toml ``` idle-timeout = 40 ``` ![helix_completion](https://user-images.githubusercontent.com/20379044/160968931-8657fa58-2d68-4a29-a118-cdc2dd6b23aa.png)

> Hey @cossonleo I want to finally get this merged but I'm trying to understand the fix. Does it immediately set a save point, then when completion data arrives it...

@archseer The PR is ready for merging. Do you have any other suggestions.

> Looks like my comments didn't get posted last time: I think moving `doc.savepoint()` before the callback is the only change needed to fix the completion. Why is savepoint now...

> This looks great! > > Could you render the tree with ASCII like this: > > ``` > exa --tree --level=2 rust/rust-ansi-parse > rust/rust-ansi-parse > ├── bin > │...

> I have just tried it and it works very well. These are the only problems that I've had so far: > > * The tree view does not support...

> This looks great! > > Could you render the tree with ASCII like this: > > ``` > exa --tree --level=2 rust/rust-ansi-parse > rust/rust-ansi-parse > ├── bin > │...

> I wanted to do something like this later on like doom emacs space space so the feature might intersect with this a bit (but didn't work on it yet)....