Carlos O'Ryan

Results 490 comments of Carlos O'Ryan

@scotthart thinks this is done. Double checking

> @coryan When is it safe to do this? gRPC releases every 6 weeks or so, the robots send us PRs to update our builds the first Monday after each...

Well, this makes me sad: I expected gRPC to follow, oh, I don't know, 30 years of software development conventions and include a macro declaring its version... I cannot find...

Oh, and I forgot to mention, at least one of our builds compiles with `warnings-as-errors` and with `clang-tidy` turned on.

Strike 2. Let's see if we have increased the minimum gRPC version to > 1.38 the next time (we are currently at 1.35).

No time this quarter, but I am hoping to get to it next quarter.

Still working on this, needs some refactoring.

https://source.cloud.google.com/results/invocations/caf2931a-fe4c-4496-816e-ffc19a847a7b

https://source.cloud.google.com/results/invocations/8632bc7a-fe86-4442-bb17-6d20ec5cdb28

https://source.cloud.google.com/results/invocations/4abece1b-0e1c-4f57-9433-9b077938446c