Carlos O'Ryan

Results 490 comments of Carlos O'Ryan

FWIW, I think #820 is a duplicate of this bug.

Note that this is surprising folks in weird places, e.g. https://github.com/conan-io/conan-center-index/issues/5766

Abseil already adds the `cxx_std_11` property to its CMake targets: https://github.com/abseil/abseil-cpp/blob/c2ef7033380a3d8661fee76465097422170fb653/CMake/AbseilHelpers.cmake#L259-L263 I would argue that when compiled with C++ >= 17, Abseil should set this property to `cxx_std_17`. That will...

> So basically something like this (untested)? Basically. Note that many compilers default to C++14, so even if `ABSL_CXX_STANDARD` is not set the effective version is C++14. Likewise, a smaller...

/testing: @googleapis/cloud-cxx-team

/testing: @googleapis/cloud-cxx-owners