Nicola Corti

Results 1291 comments of Nicola Corti

> detect GQL request based on the operation names? Yup we can have a combination of the two

Can you please fill the issue template?

> The gh graphql script to download the release artifacts doesn't seem to work Which script are you referring to?

> In the setup procedure on the github security scanning there is a yml file pregenerated. It has inline graphql code that extracts the checksums and the release artifacts. Sorry...

You'll have to suppress the deprecation locally inside `PotentialBugProvider` as otherwise the CI is red. ``` w: /home/runner/work/detekt/detekt/detekt-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/PotentialBugProvider.kt: (23, 13): 'DuplicateCaseInWhenExpression' is deprecated. Rule deprecated as compiler performs this check...

I think you'll have to inline it: ```kotlin listOf( AvoidReferentialEquality(config), Deprecation(config), DontDowncastCollectionTypes(config), DoubleMutabilityForCollection(config), @Suppress("DEPRECATION") DuplicateCaseInWhenExpression(config), ElseCaseInsteadOfExhaustiveWhen(config), EqualsAlwaysReturnsTrueOrFalse(config), ```

You have more warnings: ``` w: /home/runner/work/detekt/detekt/detekt-rules-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/DuplicateCaseInWhenExpressionSpec.kt: (9, 27): 'DuplicateCaseInWhenExpression' is deprecated. Rule deprecated as compiler performs this check by default w: /home/runner/work/detekt/detekt/detekt-rules-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ElseCaseInsteadOfExhaustiveWhenSpec.kt: (13, 27): 'ElseCaseInsteadOfExhaustiveWhen' is deprecated. Rule deprecated...

> I didn't see them while running `./gradlew clean build`. Maybe there's a simple command to purge Gradle's cache without downloading dependencies? You should be able to replicate locally with:...

> Add rule deprecation mechanism Can we also update the title of this PR mentioning which rule we deprecated?

FYI for everyone: We're holding on here as @vbuberen was also working on this (apologize for taking a stance at it) with a different approach on Permission request which we...