chucker icon indicating copy to clipboard operation
chucker copied to clipboard

Add support for Android 13

Open cortinico opened this issue 2 years ago • 1 comments

:camera: Screenshots

chucker-notification-permission

:page_facing_up: Context

This commit adds support for Android 13 and add supports for requesting the notification permission.

:pencil: Changes

  • Bump of compileSdk to 33
  • Bump of appcompat to 1.5.0
  • Adding support for a Chucker.requestNotificationPermission util method to help users request the Notification permission.

Apps that are already requesting such permission, should not use the method and Chucker will just work.

:paperclip: Related PR

Fixes #854 Closes #869 Closes #881

:hammer_and_wrench: How to test

Tested on an API 33 emulator. On Api <= 32 Chucker works correctly.

:stopwatch: Next steps

We might want to backport this to 3.x?

cortinico avatar Sep 10 '22 14:09 cortinico

FYI for everyone: We're holding on here as @vbuberen was also working on this (apologize for taking a stance at it) with a different approach on Permission request which we might want to merge instead 👍

cortinico avatar Sep 12 '22 13:09 cortinico

Closing this one as #887 is merged already.

vbuberen avatar Sep 29 '22 08:09 vbuberen