Cory Snider

I'm also unconvinced by the patch. If the problem is that pending bytes aren't flushed when committing/closing the writer, why not just flush twice when committing or closing the writer?...

> 1. We only ever flush parts when the _client_ explicitly asks for it via `Commit` or `Close`. We are flushing as soon as both buffers fill up. https://github.com/distribution/distribution/blob/79ef555f8a43d94a98a3056b10e09c1bc9a90684/registry/storage/driver/s3-aws/s3.go#L1514-L1519 >...

From https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/ > The goal of this specification is to unify the environment variable names between different OpenTelemetry implementations. > > Implementations MAY choose to allow configuration via the environment...

Don't use BuildKit as an example of _any_ OTEL best practices. It is abusing the OpenTelemetry SDK in awful ways which inflicts tremendous pain on the Moby project.

> I would just expect that the default configuration would default to not being configured, expecting that something like tracing should be something where it explicitly needs to be enabled....

Environment variables are for users to configure, and are literally global variables. We shouldn't tamper with them ourselves unless we have no other choice. I don't think we should modify...

> What are your thoughts on this? Would you prefer adherence to the current log format, or is there flexibility for change in the structure of our logs? It's a...

Conventional Commits would go a long way to enforce SemVer, but it relies on the author and reviewers to not make any mistakes. Tooling like https://pkg.go.dev/golang.org/x/exp/cmd/gorelease would help catch unintentional...

Hmm, looks like the vieux/sshfs plugin [is authored incorrectly](https://github.com/vieux/docker-volume-sshfs/blob/1e0cd2fcb72d6af0a2ad4689faed8c312124517c/config.json#L32-L44), making it incompatible with rootless docker. Managed plugins should not be requesting a bind-mount of the (default path to the rootful)...

> mount /etc/hosts:/etc/hosts (via /proc/self/fd/6), flags: 0x5021: operation not permitted Interesting... What happens if you do `docker run --rm --net=host hello-world` on the affected install?