Cory Snider

icon indicating an email [email protected]

icon company @Mirantis icon location Waterloo, ON, Canada

Results 223 comments of Cory Snider

don't use canceled context to send TERM signal to healthcheck process

@thaJeztah @cpuguy83 @tianon PTAL

don't use canceled context to send TERM signal to healthcheck process

@thaJeztah your branch LGTM; push away! I have no strong feelings either way regarding the newline in the timeout msg.

docker images ls --digests provides different output if tag provided or not

I can reproduce this with v22.06.0-beta.0-200-g98d8343aa2

setcap in dockerfile not persistent in parent dockerfile

_Possibly_ related? - https://github.com/moby/moby/issues/20435

Refactor libcontainerd to minimize containerd RPCs

``` === FAIL: amd64.integration-cli TestDockerSuite/TestExecAPIStartValidCommand (0.96s) docker_api_exec_test.go:187: assertion failed: inspectJSON.ExecIDs is not nil --- FAIL: TestDockerSuite/TestExecAPIStartValidCommand (0.96s) ``` This test passed in the prior CI run so it's ~likely~ some...

Stop shallow-cloning remote Git build contexts by default

> > Full clones would be the new default, following the principle of least surprise. Users would need to opt into shallow clones, explicitly accepting all the caveats and limitations...

libnetwork: refactor networkdb test implementation

`t.Helper()` does the trick: ```console root@fbf8cd893314:/go/src/github.com/docker/docker# go test -run TestNetworkDBNodeJoinLeaveIteration ./libnetwork/networkdb/ --- FAIL: TestNetworkDBNodeJoinLeaveIteration (3.81s) networkdb_test.go:510: timeout hit after 3s: current number of nodes is 1, expect 42. FAIL FAIL...

libnetwork: refactor networkdb test implementation

@thaJeztah PTAL

Add OpenTelemetry tracing instrumentation support

The client sets the metadata on the request before calling the interceptor, and the method to set the metadata on the request is unexported, so interceptors cannot alter the request's...

Introduce config option for MTU of newly created networks

The drivers are responsible for setting MTU. And the only drivers today which do so are bridge and overlay. I much prefer the idea of introducing a new "Max MTU"...