Corentin SORIANO

Thank you for your response. I have just installed version 3.0.0-rc2. This time, I am receiving a 401 error even before reaching getLoginFilterValues(), just like in version 2.6.0. Web authentication...

> Just one request - `#define` things that should be constants. Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?

> > > Just one request - `#define` things that should be constants. > > > > > > Shouldn’t I rather follow the existing style where the key/terminal codes...

> > > > > Just one request - `#define` things that should be constants. > > > > > > > > > > > > Shouldn’t I rather...

@jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this?

> > @jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this? > > To match our guidelines and existing...

We must keep this existing logic : - first row = start_col to $ - middle rows = ^ to $ - last row = ^ to end_col With `guac_terminal_clipboard_append_row(terminal,...

I've reworked this PR, it's ready for review!

> @corentin-soriano The changes look good to me, although @mike-jumper and @jmuehlner are more familiar with the terminal implementation, so I'm curious if either of them has any feedback on...

@necouchman, @jmuehlner, have you any other comments on this PR?