Simon Schubert

@emaste I think an error in `getline` will get undetected and return success. Otherwise looks like an acceptable way to address such mails.

I think we can keep the `feof()` loop condition, but just do something about error return from `getline`.

could you show more of the snipped lines from maillog? On 30/06/2021 06:37, Oscar Carlsson wrote: > > Hi, > > I'm using dma on a FreeBSD 13 machine with...

you need to remove STARTTLS if you use port 465. 587 + STARTTLS should be preferred. The stack overflow is definitely a bug though.

could you attach with gdb and show a backtrace? It's not clear what leads to the stack overflow.

You need mailutils if you want the mail command. mail is not part of dma. dma should read the aliases file and also apply it for root.

when we designed the dma architecture, we deliberately decided against running commands, because it requires running as setuid root and increases the vulnerability surface significantly. if you need command aliases,...

Why do we have to store the headers in the queue structure?

I mean, can we just rewrite the header on the fly, without storing it? On 17/04/2021 05:37, Jernej Jakob wrote: > > You're right, it's a global variable so it...

I guess I don't understand.  In my mind, we see the From: line, then insert a X-Original-From: (maybe with newline continuation), then the contents of the From line, and all...