Fabian
Fabian
I don't think I want to take on the large mitm.mjs dependency in the default build of v86. I'd accept the following: - comment out the test (remove mitm.mjs from...
I'm curious, what do you want to use this for?
And how does fetch mode come into play? Do you host a page with v86? Do you host the page that is being fetched via v86?
Apologies about the delay in reviewing. Overall this looks great, but I am struggling a bit with this PR for several reasons: 1. The highly oop-style with several classes, exceptions...
Needs a rebase and perhaps a quick code review from one of @ProgrammerIn-wonderland, @ading2210 or @chschnell
Possible solutions: - document that esm users need to add `window["Terminal"] = Terminal` somewhere - accept the Terminal constructor as a parameter to V86 Feel free to send a PR...
Fix in #12
What is this used for? I don't mind having this in the code, but unless there's particularly interesting public endpoints, I don't think this should occupy space in the UI.
You can use tools/split-image.py. It's kinda documented here: https://github.com/copy/v86/blob/db22e06746d7adfd3b8c01be29fd15dea4b3bd37/v86.d.ts#L17-L19 But I agree that it could be documented better.
Please don't post LLM generated issues. I will leave this one open as it's (probably) valid, but in general it creates an imbalance between reporters (who don't have to put...