Ryan de Kleer

Results 13 comments of Ryan de Kleer

Looking at this more, I'm seeing that the tests *fail due to xdist*: there's now race conditions on the global root logger... I can get around this by testing `log.init()`...

Sorry if this is the wrong place to put this, but rather than change the length of the tuple in LOG_FILTERs values, what about using ``re.compile`` when regex is desired?...

> @copperchin Do you mean we expect users to provide compiled regular expressions? And handle it internally with an `isinstance` check? It would work, technically, but I worry about the...

Yes, I'll take another look at this. I don't actually remember why this stalled but, reviewing the notes here, it looks like this might have been blocked by a deeper...

So I think this stalled because I became mired in a lot of unrelated test failures. At first, I was getting a very large number of test failures due to...

@avaris Thanks! I think I had a breakthrough that resolved most of the issues when I last looked at it. I haven't had much time at my machine for the...

Just working on adding some tests, doing some cleanup, and adding docstrings to my changes. I have a couple of questions regarding style preferences for pelican code: 1. I don't...

@avaris Yeah I see what you mean; I initially started adding type hints for new content but it felt so out of place that it seemed more distracting than helpful....

Funny you should bring that up; I came across https://github.com/getpelican/pelican/issues/2893 yesterday and commented there -- missed the PR #3108 though. My suggestion was to keep the 2-tuple form and just...

Thanks for the in-depth review @avaris ! This is a pretty big diff, so I really appreciate the effort. I'm hoping to be able to get revisions up here in...