Luke Rodgers
Luke Rodgers
Thanks @a-dite i will review more thoroughly tomorrow :) @hostep I see you've 🎉 'd this, any thoughts ? :) And @peterjaap the recommended `diff` command may be changing, not...
@peterjaap output is the same now only contains new row types like ```diff | Preference | vendor/magento/module-weee/Model/Total/Quote/Weee.php | Ampersand\Test\Model\Total\Quote\Weee | + | Queue consumer added | vendor/magento/module-inventory-indexer/etc/queue_consumer.xml | inventory.indexer.sourceItem |...
> Maybe similar logic can be used for discovering changes in other type of xml files (like adminhtml/system.xml to see if configuration settings were added/removed). Just an idea, not sure...
`--very-good-point` @hostep I'll pop an issue on later
@peterjaap What version moving from and to? and chance you can share the relevant part of the diff for `vendor/magento/module-sales-rule/etc/queue_consumer.xml` ?
Thanks @peterjaap I should be able to get a test case in for this and work it out.
Fixed the above https://github.com/AmpersandHQ/ampersand-magento2-upgrade-patch-helper/releases/tag/v1.10.1
Hey @hostep This is a very interesting idea. Skirting around the edges of making this tool have sort of [semantic diff](https://www.martinfowler.com/bliki/SemanticDiff.html) functionality? The copyright header was a massive pain wasn't...
Hey @arosenhagen The reason the newest changes are not included in the SUPEE-4755 patch is that they are not an "official" patch from Magento. SUPEE-4755 was released after Magento reviewed...
Yeah. Sadly thats about as "official" as this is going to get. If you have an ongoing Enterprise licence agreement with Magento I believe you should be able to open...