Luke Rodgers
Luke Rodgers
@jmalloc Currently debugging the same, looking here suggests it may be in newer version? https://github.com/docker/compose/pull/5985#issuecomment-683395676 edit: just realised thats `docker-compose` and not `docker compose` I was able to install the...
> but an empty vendor.patch doesn't work Yeah the entire point of this tool is to isolate in on only things that have changed in the upgrade that you have...
@onlinebizsoft Looks like i'm matching against the module correctly for this override, but matching the end of `default.xml` when i should be looking for `/default.xml` very likely. Yes a bug,...
Inspiration at https://github.com/shopware/platform/pull/1232/files thanks @peterjaap
Making the tests assert on the results of JSON output will be much easier to handle and assert against.
Just back after a period of annual leave. This looks neat, will review once I've cleared by backlog a bit.
Also just in case you're curious, I have managed this a bit differently using static analysis in our projects. We define all the consumers we want to run in `app/etc/config.php`...
@a-dite does it work if you do `diff -ur -N vendor_orig/ vendor/ > vendor.patch` ? I think it won't be flagging any issues as this is mainly for detecting overwrites/overrides,...
@a-dite I thought that might be it 😬 It's kind of how this tool is opinionated and focussing in on only things that change when you upgrade. So if something...
Hey @a-dite if you cherry pick in c1087ece216e194bd70e87c402c7c9ffb3388057 there are only two test files needing updated to get it ✅ https://app.travis-ci.com/github/AmpersandHQ/ampersand-magento2-upgrade-patch-helper/jobs/581582666 ``` There were 2 failures: 1) FunctionalTests::testMagentoTwoThree Failed asserting...