storage
storage copied to clipboard
containers
Container Storage Library
c/image calls `chunked.GetDiffer` immediately followed by `store.ApplyDiffWithDiffer` ~ `differ.ApplyDiff`. Currently `convert_images` happens in the latter call; but that means it happens with the layer store locked for writing. It seems...
### Issue Description ``` goroutine 35983 [syscall]: runtime.cgocall(0x5900642c14a0, 0xc002411958) /usr/lib/golang/src/runtime/cgocall.go:157 +0x4b fp=0xc002411930 sp=0xc0024118f8 pc=0x590063012d6b github.com/containers/podman/vendor/github.com/containers/storage/pkg/idtools._Cfunc_subid_get_uid_ranges(0x79fd08039780, 0xc001e80048) _cgo_gotypes.go:123 +0x4f fp=0xc002411958 sp=0xc002411930 pc=0x5900633f7fcf github.com/containers/podman/vendor/github.com/containers/storage/pkg/idtools.readSubid.func3(0xc000b67c50?, 0x4?) /builddir/build/BUILD/containers-podman-1a6dca2/_build/src/github.com/containers/podman/vendor/github.com/containers/storage/pkg/idtools/idtools_supported.go:55 +0x4a fp=0xc002411998 sp=0xc002411958 pc=0x5900633f880a github.com/containers/podman/vendor/github.com/containers/storage/pkg/idtools.readSubid({0xc000b67c24, 0x7},...
According to the discussion in #1579, enable the linter `stylecheck` and disable rule `ST1003`.
According to the discussion in #1579, enable linter `dupl`, set the threshold to `200` and exclude tests from linting.
Today, ``` [storage.options.overlay] use_composefs = "true" ``` Actually also requires: ``` [storage.options] pull_options = {convert_images = "true"} ``` And it's especially the `convert_images = true` that adds huge latency to...
currently an invalid pull option is just ignored instead of reporting an error to the caller.
Today the composefs backend basically does "enable fsverity if we can" by default. In the code, there is a [proper enum](https://github.com/containers/storage/blob/b7750dc177bb539f3684e29964b4a5b01508dc34/drivers/driver.go#L233) but AFAICS it is not exposed via e.g. `storage.conf`...
### Issue Description While running with the ZFS driver, maybe one out of every 50 containers ends up with the following error ``` cleaning up storage: removing container 8941b7366dfbe5deb66554f86be2f1c931e510e1d770ed00bdd49c56aaa46c18 root...
### Issue Description Running with the zfs driver and about 200 containers on host, the driver becomes extremely slow. We're talking 30s to do podman ps ### Steps to reproduce...