storage

storage copied to clipboard

During the lint CI job, `hack/git-validation.sh` failed with `fatal: Not a valid object name main`. Log: https://api.cirrus-ci.com/v1/task/5169202091261952/logs/test.log

Honny1

somehow got `application/vnd.oci.image.layer.v1.tar+gzip` with zstd:chunked annotations

1

I was messing around with zstd:chunked and somehow ended up with this: ``` skopeo inspect -n docker://quay.io/cgwalters/ostest:zstdchunked { "Name": "quay.io/cgwalters/ostest", ... "LayersData": [ { "MIMEType": "application/vnd.oci.image.layer.v1.tar+zstd", "Digest": "sha256:b8f741b50c9da370750578605c48ada1a67d01eea3bdae9ce09599c44dad7bfc", "Size": 3493473,...

cgwalters

OOMs in zstd code with zstd:chunked

3

I am consistently getting `skopeo` being OOM killed when running this to convert a local overlay image I have to an OCI zstd:chunked format (so I can easily inspect/debug it):...

cgwalters

Use `slices` and `maps` more where appropriate

1

Please see individual commits for details.

kolyshkin

ci: add nolintlint and unconvert linters, fix found issues

1

Please review commit by commit. See individual commits for details.

kolyshkin

Use for range over integers

1

This form is available since Go 1.22 (see https://tip.golang.org/ref/spec#For_range) and will probably be seen more and more in the new code.

kolyshkin

Use any instead of interface{}

1

It's available since Go 1.18 (see https://pkg.go.dev/builtin#any).

kolyshkin

Use min/max to simplify the code

1

Should not change functionality.

kolyshkin

Improve error handling in archive creation

10

hanwen-flow

RFC: Remove drivers/windows

5

Compare https://github.com/containers/storage/issues/2009 : The code could never build its unit tests since September 2017, and nobody seems to have complained. Also, see how this impacts `go.mod`: many of the largest...

mtrmac